From: Brandon Turner <bt@brandonturner.net>
Date: Wed, 08 Oct 2014 21:50:16 GMT
Subject: Re: [PATCH] completion: ignore chpwd_functions when cding
Message-ID: <CAMUzdXkQcbwhmJRYog+X_9B_cdWv6FkTrVFT__Dsw2k+qKN0=g@mail.gmail.com>
In-Reply-To: <xmqqh9zebfc6.fsf@gitster.dls.corp.google.com>

On Wed, Oct 8, 2014 at 1:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>
> Can you mention that this is abomination limited only to zsh
> somewhere in the log message?  Or does bash share the same glitch?
>
> If this is limited to zsh, I wonder if we can take advantage of the
> fact that we have git-completion.bash and git-completion.zsh to
> avoid contaminating shared part of the code.

I'm going to submit two versions of the patch:
v2 - addresses the log message, but the patch still applies to bash
and zsh
v3 - moves the change to git-completion.zsh as an override, bash is
unaffected

>From my testing, bash is unaffected, so v3 would be an ok fix.  Since
we cannot control what functions users add to chpwd_functions, v2 might
make more sense.