Re: [PATCH v3 1/4] send-email: make annotate configurable

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 7, 2013, 17:58 UTC
Message-ID: <CAMP44s3bdFfZRGL1BHtODiad6ZXD_xy1MfUhNPrJQV=L4hGamw@mail.gmail.com>
In-Reply-To: <7vvc7y45nf.fsf@alter.siamese.dyndns.org>

On Sun, Apr 7, 2013 at 12:22 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Sun, Apr 7, 2013 at 1:42 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> Some people always do --annotate, lets not force them to always type
>>>> that.
>>>>
>>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>>> ---
>>>
>>> Sounds sensible; any tests to protect this from later breakages?
>>
>> Given that annotate doesn't even have tests, I don't think it's needed
>> at this point.
>
> That is a good way to spread earlier mistakes and add more instance
> of the same kind of mistakes into the future.
>
> It is perfectly fine to say "I ran out my Git time for the change
> itself; help by others to add test for it is appreciated."  It is
> not reasonable to say "See there is the same mistake already in the
> code, so I am free to make the same mistake, you cannot hold it
> against me, and this feature should never be protected by tests".

I did not say that, I said I think this is not needed at this point, if you think otherwise, you can go ahead and implement it. I think the patch is perfectly fine as it is, and I'm not going to to add tests for something that is potentially time consuming for me, and this patch is not introducing, that is; the annotate feature. If we survived without tests for annotate, we can survive without tests for sendemail.annotate.

-- 
Felipe Contreras