Re: [PATCH v3 4/4] format-patch: add format.cover-letter configuration

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 7, 2013, 09:11 UTC
Message-ID: <CAMP44s1pMLzkQrE1iKmYyj_FOZqkUp46HRQ6kjWfNvOYA5FkVQ@mail.gmail.com>
In-Reply-To: <7vmwta7lx3.fsf@alter.siamese.dyndns.org>

On Sun, Apr 7, 2013 at 4:03 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Users know how to count, if the default is no cover-letter, then doing
>> --cover-letter=auto is basically --cover-letter, unless they don't
>> know how to count and thought --cover-letter=auto would do something.
>> The same is true is they configured coverletter=true.
>
> The user who says "format-patch origin" does not necessarily have to
> count beforehand with "rev-list origin..", so "Users know how to
> count" does not sound like a relevant and convincing argument to me.

So, I'm a user that does 'git format-patch --cover-letter=auto origin' so I don't have the format.coverletter=auto configuration. Why? Why am I not setting that configuration, and why am I running --cover-letter=auto?

The only reason I can think of is that I ran 'git format-patch origin' and it didn't do what I wanted (or I knew befeorehand).

What other reason could the user possibly have?

-- 
Felipe Contreras