Re: [PATCH v3 1/4] send-email: make annotate configurable

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 7, 2013, 17:22 UTC
Message-ID: <7vvc7y45nf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s0g5YfvprwukJ4rnqXrm+S9-KJkwyYB+sxAcQjZpDXufg@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 13 quoted lines

> On Sun, Apr 7, 2013 at 1:42 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> Some people always do --annotate, lets not force them to always type
>>> that.
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>> ---
>>
>> Sounds sensible; any tests to protect this from later breakages?
>
> Given that annotate doesn't even have tests, I don't think it's needed
> at this point.

That is a good way to spread earlier mistakes and add more instance of the same kind of mistakes into the future.

It is perfectly fine to say "I ran out my Git time for the change itself; help by others to add test for it is appreciated." It is not reasonable to say "See there is the same mistake already in the code, so I am free to make the same mistake, you cannot hold it against me, and this feature should never be protected by tests".