Re: [PATCH v3 2/4] format-patch: improve head calculation for cover-letter

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 7, 2013, 08:36 UTC
Message-ID: <CAMP44s1tHdqKmMJbc6_zwEFZ-bK_boSX5zBu1zeBizJ8QVh2uw@mail.gmail.com>
In-Reply-To: <7vbo9q93u2.fsf@alter.siamese.dyndns.org>

On Sun, Apr 7, 2013 at 1:50 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> If we do it after the revision traversal we can be sure that this is
>> indeed a commit that will be processed (i.e. not a merge) and it's the
>> top most one (thus removing the NEEDSWORK comment).
>
> There may not be a single top-most one anyway (which is what that
> "randomly pick" comment refers to and punts), so taking the tip
> after traversal is just as good as doing it before.  So this is a
> good change, but it still is punting.

Yeah, I thought of looking at 'git diff' and do the same thing, but then I realized 'git diff --stat' has the same issue, so I don't think it really matters.

-- 
Felipe Contreras