Re: [PATCH 3/5] run-command: drop silent_exec_failure arg from wait_or_whine
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Nov 11, 2012, 18:13 UTC
- Message-ID
- <CAMP44s3_CDHhcEe_ponW__=TdG_c1DQyLU1VG4UCzOC=MxW9mQ@mail.gmail.com>
- In-Reply-To
- <20121111165544.GC19850@sigill.intra.peff.net>
On Sun, Nov 11, 2012 at 5:55 PM, Jeff King <peff@peff.net> wrote:
> We do not actually use this parameter; instead we complain > from the child itself (for fork/exec) or from start_command > (if we are using spawn on Windows).
FWIW I noticed the same while looking at that code. Looks good to me.
-- Felipe Contreras