Re: [PATCH 0/5] ignore SIGINT while editor runs

From: Krzysztof Mazur <krzysiek@podlesie.net>
Date: Nov 11, 2012, 19:15 UTC
Message-ID: <20121111191520.GA9474@shrek.podlesie.net>
In-Reply-To: <20121111163100.GB13188@sigill.intra.peff.net>

On Sun, Nov 11, 2012 at 11:31:00AM -0500, Jeff King wrote:

Show 17 quoted lines

> 
> Here's a series that I think should resolve the situation for everybody.
> 
>   [1/5]: launch_editor: refactor to use start/finish_command
> 
> The cleanup I sent out a few minutes ago.
> 
>   [2/5]: launch_editor: ignore SIGINT while the editor has control
> 
> Paul's patch rebased on my 1/5.
> 
>   [3/5]: run-command: drop silent_exec_failure arg from wait_or_whine
>   [4/5]: run-command: do not warn about child death by SIGINT
>   [5/5]: launch_editor: propagate SIGINT from editor to git
> 
> Act more like current git when the editor dies from SIGINT.
>

Looks ok, but what about SIGQUIT? Some editors like GNU ed (0.4 and 1.6) ignore SIGQUIT, and after SIGQUIT git dies, but editor is still running. After pressing any key ed receives -EIO and prints "stdin: Input/output error". GNU ed 1.6 then exits, but ed 0.4 prints this error forever. Maybe git should kill the editor in such case?

Krzysiek