From: Felipe Contreras Date: Sun, 11 Nov 2012 18:13:00 GMT Subject: Re: [PATCH 3/5] run-command: drop silent_exec_failure arg from wait_or_whine Message-ID: In-Reply-To: <20121111165544.GC19850@sigill.intra.peff.net> On Sun, Nov 11, 2012 at 5:55 PM, Jeff King wrote: > We do not actually use this parameter; instead we complain > from the child itself (for fork/exec) or from start_command > (if we are using spawn on Windows). FWIW I noticed the same while looking at that code. Looks good to me. -- Felipe Contreras