Re: [PATCH v2 7/8] revert/cherry-pick: add --quiet option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 29, 2013, 13:40 UTC
Message-ID: <CAMP44s38xDmqtzLNB44=HKQd8R+3S=edN3LS40GFfp7wfqi3hw@mail.gmail.com>
In-Reply-To: <CALkWK0=VieCwZS4ua-eyg3t-cqC2Y+ifa-G7gwJ=Mxt0cfoD1g@mail.gmail.com>

On Wed, May 29, 2013 at 8:32 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 9 quoted lines

> Felipe Contreras wrote:
>> Did you miss the -q option passed to 'git commit'?
>
> Ah, yes.
>
> It would help if you mentioned:
>
>     Introduce --quiet to suppress warning about skipped commits (when
> using --skip-empty) and output from 'git commit'.

I would switch them around, as the former is not important, in fact, it's so unimportant that I wouldn't even mention it.

And in fact, it wasn't even there when I wrote this commit message I sent for v1, it was only squashed later on.

The only really important thing this patch does is 'commit -q', and I cannot imagine what the purpose of a -q option to cherry-pick would be if it's not that. But yeah, it wouldn't hurt.

-- 
Felipe Contreras