Re: [PATCH v2 3/8] cherry-pick: add --skip-empty option

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2013, 17:35 UTC
Message-ID: <7vbo7l93t6.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s2DvtiT6hi-RoPt_bVdGr01S367usz=089E1Ht+Bvh-tA@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 8 quoted lines

>> I think just "Skip commits that are or become empty" without saying
>> "Instead of failing," is fine, too.
>
> I think "Instead of failing" makes perfect sense, because it's not our
> job to describe what other options do,...
> ...
> simply explain what this option
> do.

Which means "Skip commits" and nothing else. Saying "Instead of failing" explains what would happen if you ran the command without any option, which is entirely irrelevant, just like the case when you ran the command without an unrelated option --allow-empty.

We share the same "the --skip-empty option does not have anything to do with the --allow-empty option, and we do not have to say anything about what happens when the command is run with that unrelated option".

But we are viewing it from a different angle.