Re: [PATCH v2 4/8] cherry-pick: store rewritten commits
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 3, 2013, 18:49 UTC
- Message-ID
- <7vmwr7do7s.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1369799788-24803-5-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 7 quoted lines
> +static void add_rewritten(unsigned char *from, unsigned char *to)
> +{
> + struct rewritten_list_item *item;
> + if (rewritten.nr + 1 >= rewritten.alloc) {
> + rewritten.alloc += 32;
> + rewritten.items = xrealloc(rewritten.items, rewritten.alloc * sizeof(*rewritten.items));
> + }Is there a compelling reason not to use ALLOC_GROW() here?