Re: [PATCH v2 7/8] revert/cherry-pick: add --quiet option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 29, 2013, 13:28 UTC
Message-ID: <CAMP44s0M8dg_8ke3p1wJtnPrjdtH0L-D3ZgnPPCSKH0Mx0Z=GA@mail.gmail.com>
In-Reply-To: <CALkWK0=QyznWZt4sJCok9OZxjrdjtMTtpStA8LHdCCbn0Oi6TA@mail.gmail.com>

On Wed, May 29, 2013 at 7:33 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 14 quoted lines

> Felipe Contreras wrote:
>>         if (opts->skip_empty && is_index_unchanged() == 1) {
>> -               warning(_("skipping %s... %s"),
>> -                       find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
>> -                       msg.subject);
>> +               if (!opts->quiet)
>> +                       warning(_("skipping %s... %s"),
>> +                               find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
>> +                               msg.subject);
>>                 goto leave;
>>         }
>
> All this trouble just to suppress the "skipping ..." message.  Do you
> see anything else --quiet can be used to suppress?

Did you miss the -q option passed to 'git commit'?

-- 
Felipe Contreras