Re: [PATCH] test: simplify counts aggregation

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mar 8, 2023, 10:04 UTC
Message-ID: <CAMP44s34bvRP1n3L57sK450ZfLUeVQKVtXDXrE75qM46xaCgcw@mail.gmail.com>
In-Reply-To: <20230308092621.M321240@dcvr>

On Wed, Mar 8, 2023 at 3:26 AM Eric Wong <e@80x24.org> wrote:

Show 13 quoted lines

>
> > On Wed, Mar 08 2023, Felipe Contreras wrote:
> > > +++ b/t/Makefile
> > > +   '$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)/t*-*.counts'
>
> > > +++ b/t/aggregate-results.sh
> > >
> > > -while read file
> > > +for file in $1
>
> Reading aggregate-results.sh alone looks wrong; but your patch is
> correct overall because of how it's invoked from the Makefile.
> I think that's too subtle...

Yeap, it's the first time I read it, I don't actually use it, and it's broken for my use case:

    testnum=$(expr "$file" : 'test-results/\(t[0-9]*\)-')

That doesn't work when TEST_OUTPUT_DIRECTORY is set (which I always have); should be ".*test-results".

I don't actually care how many thousands of tests have been run, the only functionality that might be useful to me is the number of fixed tests (namely that it's higher than 0). Maybe a summary-results.sh might make more sense.

Cheers.

-- 
Felipe Contreras