git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] test: simplify counts aggregation

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Mar 8, 2023, 09:05 UTC
Message-ID
<20230308090536.2562917-1-felipe.contreras@gmail.com>

When the list of files as input was implemented in 6508eedf67 (t/aggregate-results: accomodate systems with small max argument list length, 2010-06-01), a much simpler solution wasn't considered.

Let's just pass the pattern as an argument.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/Makefile             | 4 +---
 t/aggregate-results.sh | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/t/Makefile b/t/Makefile
index 2c2b252240..6bc878558f 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -140,9 +140,7 @@ aggregate-results-and-cleanup: $(T)
 	$(MAKE) clean
 
 aggregate-results:
-	for f in '$(TEST_RESULTS_DIRECTORY_SQ)'/t*-*.counts; do \
-		echo "$$f"; \
-	done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh
+	'$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)/t*-*.counts'
 
 valgrind:
 	$(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind"
diff --git a/t/aggregate-results.sh b/t/aggregate-results.sh
index 7f2b83bdc8..2efc2c37cd 100755
--- a/t/aggregate-results.sh
+++ b/t/aggregate-results.sh
@@ -8,7 +8,7 @@ broken=0
 total=0
 missing_prereq=
 
-while read file
+for file in $1
 do
 	while read type value
 	do
-- 
2.39.2
Next: Ævar Arnfjörð Bjarmason
Message 1 of 7 in “test: simplify counts aggregation”
  1. test: simplify counts aggregationFelipe Contreras, Mar 8, 2023
  2. Ævar Arnfjörð BjarmasonMar 8, 2023
  3. Eric WongMar 8, 2023
  4. Felipe ContrerasMar 8, 2023
  5. Felipe ContrerasMar 8, 2023
  6. Ævar Arnfjörð BjarmasonMar 8, 2023
  7. Felipe ContrerasMar 8, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.