Re: [PATCH] test: simplify counts aggregation

From: Eric Wong <e@80x24.org>
Date: Mar 8, 2023, 09:26 UTC
Message-ID: <20230308092621.M321240@dcvr>
In-Reply-To: <230308.86bkl3zjp3.gmgdl@evledraar.gmail.com>

> On Wed, Mar 08 2023, Felipe Contreras wrote:
> > +++ b/t/Makefile
> > +	'$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)/t*-*.counts'

> > +++ b/t/aggregate-results.sh
> >  
> > -while read file
> > +for file in $1

Reading aggregate-results.sh alone looks wrong; but your patch is correct overall because of how it's invoked from the Makefile. I think that's too subtle...

Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> I think we can go even further here, and just pass the
> $(TEST_RESULTS_DIRECTORY_SQ) as an argument to the script

Yes.