Re: [PATCH] test: simplify counts aggregation

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mar 8, 2023, 12:07 UTC
Message-ID: <CAMP44s2dZmrt8SDFU+vwV7AX1BJNS3jR-nu0WZJsaEKLgTtKDg@mail.gmail.com>
In-Reply-To: <230308.86ttyvxzjz.gmgdl@evledraar.gmail.com>

On Wed, Mar 8, 2023 at 5:17 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

>
> On Wed, Mar 08 2023, Felipe Contreras wrote:

Show 12 quoted lines

> > Or just:
> >
> >     for file in "${TEST_OUTPUT_DIRECTORY-.}"/test-results/t*-*.counts
> >
> > And don't pass anything.
>
> Yeah, I think that would work, but at least on an ad-hoc basis I've
> sometimes saved away the "test-results" directory
> (e.g. "test-results.prev").
>
> I think it would be useful if the script part of our tooling was happy
> to accept any name for such a directory, and then examined its contents.

That's not a problem, just pass the directory as an optional argument.

    default_dir="${TEST_OUTPUT_DIRECTORY-.}/test-results/"
    for file in "${1-$default_dir}"/t*-*.counts

> But I don't feel strongly about it, and I don't use aggregate-results.sh
> in particular (I always use "prove").

Yeah, me neither (I also use prove).

-- 
Felipe Contreras