Re: [PATCH] run-command: simplify wait_or_whine

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 1, 2013, 15:01 UTC
Message-ID: <CAMP44s2cBGc+uKH0t-KZko-5GYkZUK54+7wiYbWim55B7KGaGA@mail.gmail.com>
In-Reply-To: <CACsJy8BFv7kJkymJ_rj9dwaN-zMcHtS9sjmqDSpLWB5TsUU_kg@mail.gmail.com>

On Sat, Jun 1, 2013 at 9:36 AM, Duy Nguyen <pclouds@gmail.com> wrote:

Show 12 quoted lines

> On Sat, Jun 1, 2013 at 9:30 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> On Sat, Jun 1, 2013 at 9:21 AM, Duy Nguyen <pclouds@gmail.com> wrote:
>>> On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras
>>> <felipe.contreras@gmail.com> wrote:
>> Yeah, and last year we returned a different code. The world didn't
>> end, because nobody is checking for the specific code. But if you want
>> to retain complexity forever, suit yourselves.
>
> And that was changed for a reason, compared to this change "because I
> like it". I maintain my NAK (not that it matters) until you justify
> your change better than "nobody is using it".

Who said the reason was "because I like it"? You don't agree that making the code simpler and more maintainable is a good reason for any change?

Anyway, if you care so much about the current behavior, why isn't there any tests that check for this?

My patch passes *all* the tests.

-- 
Felipe Contreras