From: Felipe Contreras Date: Sat, 01 Jun 2013 15:01:49 GMT Subject: Re: [PATCH] run-command: simplify wait_or_whine Message-ID: In-Reply-To: On Sat, Jun 1, 2013 at 9:36 AM, Duy Nguyen wrote: > On Sat, Jun 1, 2013 at 9:30 PM, Felipe Contreras > wrote: >> On Sat, Jun 1, 2013 at 9:21 AM, Duy Nguyen wrote: >>> On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras >>> wrote: >> Yeah, and last year we returned a different code. The world didn't >> end, because nobody is checking for the specific code. But if you want >> to retain complexity forever, suit yourselves. > > And that was changed for a reason, compared to this change "because I > like it". I maintain my NAK (not that it matters) until you justify > your change better than "nobody is using it". Who said the reason was "because I like it"? You don't agree that making the code simpler and more maintainable is a good reason for any change? Anyway, if you care so much about the current behavior, why isn't there any tests that check for this? My patch passes *all* the tests. -- Felipe Contreras