git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] run-command: simplify wait_or_whine

From
Thomas Rast <trast@inf.ethz.ch>
Date
Jun 1, 2013, 14:19 UTC
Message-ID
<87wqqdoqvp.fsf@hexa.v.cablecom.net>
In-Reply-To
<1370094715-2684-1-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Nobody is checking for specific error codes; it's the errno that's
> important.
[...]
Show 6 quoted lines
> -		/*
> -		 * This return value is chosen so that code & 0xff
> -		 * mimics the exit code that a POSIX shell would report for
> -		 * a program that died from this signal.
> -		 */
> -		code += 128;

Have you checked the callers? There are lots of callers of finish_command(), which returns the value from wait_or_whine() unmodified.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Felipe ContrerasNext: Felipe Contreras
Message 6 of 15 in “run-command: simplify wait_or_whine”
  1. run-command: simplify wait_or_whineFelipe Contreras, Jun 1, 2013
  2. Duy NguyenJun 1, 2013
  3. Felipe ContrerasJun 1, 2013
  4. Duy NguyenJun 1, 2013
  5. Felipe ContrerasJun 1, 2013
  6. Thomas RastJun 1, 2013
  7. Felipe ContrerasJun 1, 2013
  8. Duy NguyenJun 1, 2013
  9. Felipe ContrerasJun 1, 2013
  10. Duy NguyenJun 1, 2013
  11. Felipe ContrerasJun 1, 2013
  12. t0005: test git exit code from signal deathJeff King, Jun 1, 2013
  13. Felipe ContrerasJun 1, 2013
  14. Jeff KingJun 1, 2013
  15. Felipe ContrerasJun 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.