git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] run-command: simplify wait_or_whine

From
Duy Nguyen <pclouds@gmail.com>
Date
Jun 1, 2013, 14:36 UTC
Message-ID
<CACsJy8BFv7kJkymJ_rj9dwaN-zMcHtS9sjmqDSpLWB5TsUU_kg@mail.gmail.com>
In-Reply-To
<CAMP44s0L1M+_s2eDM=Ogy=rxLhpZYwSb8qWTuEe30pB4KGDVtA@mail.gmail.com>

On Sat, Jun 1, 2013 at 9:30 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 6 quoted lines
> On Sat, Jun 1, 2013 at 9:21 AM, Duy Nguyen <pclouds@gmail.com> wrote:
>> On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
> Yeah, and last year we returned a different code. The world didn't
> end, because nobody is checking for the specific code. But if you want
> to retain complexity forever, suit yourselves.

And that was changed for a reason, compared to this change "because I like it". I maintain my NAK (not that it matters) until you justify your change better than "nobody is using it".

Show 5 quoted lines
> commit 709ca730f8e093005cc882bfb86c0ca9c83d345b
> Author: Jeff King <peff@peff.net>
> Date:   Sat Jan 5 09:49:49 2013 -0500
>
>     run-command: encode signal death as a positive integer
-- 
Duy
Previous: Felipe ContrerasNext: Felipe Contreras
Message 10 of 15 in “run-command: simplify wait_or_whine”
  1. run-command: simplify wait_or_whineFelipe Contreras, Jun 1, 2013
  2. Duy NguyenJun 1, 2013
  3. Felipe ContrerasJun 1, 2013
  4. Duy NguyenJun 1, 2013
  5. Felipe ContrerasJun 1, 2013
  6. Thomas RastJun 1, 2013
  7. Felipe ContrerasJun 1, 2013
  8. Duy NguyenJun 1, 2013
  9. Felipe ContrerasJun 1, 2013
  10. Duy NguyenJun 1, 2013
  11. Felipe ContrerasJun 1, 2013
  12. t0005: test git exit code from signal deathJeff King, Jun 1, 2013
  13. Felipe ContrerasJun 1, 2013
  14. Jeff KingJun 1, 2013
  15. Felipe ContrerasJun 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.