Re: [PATCH] tests: fix autostash

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 8, 2013, 14:13 UTC
Message-ID: <CAMP44s0MZ34J=C0r_V8MN-nYrDbi7buy5vOKtHU_jKRFvyGbXw@mail.gmail.com>
In-Reply-To: <CALkWK0mBnG7houMKHDorz3oSm=R7u4Va1s=AepSM0CPY6Gy4cw@mail.gmail.com>

On Sat, Jun 8, 2013 at 9:04 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 7 quoted lines

> Felipe Contreras wrote:
>>> Ofcourse they're implementation details.  Even in this very test, I
>>> check $dotest/autostash plenty of times.
>>
>> The more the test relies on implementation details, the worst.
>
> I'm not convinced about this.

There's even a model called test-driven development, where you start developing the tests even before there's any implementation. There's also black-box testing.

There's reasons for that.

Show 5 quoted lines

>>> Then show me how to do it correctly.
>>
>> Something like this.
>
> Yeah, this is definitely better.  Can you submit this patch?

Maybe, I don't know when.

-- 
Felipe Contreras