Re: [PATCH] tests: fix autostash
- From
Antoine Pelisse <apelisse@gmail.com>
- Date
- Jun 8, 2013, 14:13 UTC
- Message-ID
- <CALWbr2x4xGjYXa30vpbK4Q2WAVfmzuz1jNWFyGKSPO0To4P-0w@mail.gmail.com>
- In-Reply-To
- <CALkWK0mBnG7houMKHDorz3oSm=R7u4Va1s=AepSM0CPY6Gy4cw@mail.gmail.com>
On Sat, Jun 8, 2013 at 4:04 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
Show 7 quoted lines
> Felipe Contreras wrote: >>> Ofcourse they're implementation details. Even in this very test, I >>> check $dotest/autostash plenty of times. >> >> The more the test relies on implementation details, the worst. > > I'm not convinced about this.
My understanding of these tests is that they make sure new/better implementations don't break the user experience/defined behavior. If the test relies on the implementation, then they lose most of their interest.