git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: fix autostash

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jun 8, 2013, 16:56 UTC
Message-ID
<20130608165611.GB3109@elie.Belkin>
In-Reply-To
<CALkWK0=qVXL=DtJzYRGFLQQh3_-cGC_t_zpaiTL9KVKN4--mVg@mail.gmail.com>
Ramkumar Ramachandra wrote:
> How else am I supposed to write them?  If there is a stale state from
> the previous test, there isn't too much I can do.  Or should I be
> cleaning up state at the beginning of each test, instead of at the
> end?

That's one strategy. "test_when_finished" to restore the set-up state is another.

Making tests skippable unless labelled otherwise is currently an aspirational goal rather than a practical one. Hopefully some day we'll get there and the test harness can start checking it. :) It makes reorganizing test scripts, for example by reordering tests, much easier.

Thanks, Jonathan

Previous: Ramkumar Ramachandra
Message 10 of 10 in “tests: fix autostash”
  1. tests: fix autostashFelipe Contreras, Jun 7, 2013
  2. Ramkumar RamachandraJun 8, 2013
  3. Felipe ContrerasJun 8, 2013
  4. Ramkumar RamachandraJun 8, 2013
  5. Felipe ContrerasJun 8, 2013
  6. Ramkumar RamachandraJun 8, 2013
  7. Felipe ContrerasJun 8, 2013
  8. Antoine PelisseJun 8, 2013
  9. Ramkumar RamachandraJun 8, 2013
  10. Jonathan NiederJun 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.