git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: fix autostash

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 8, 2013, 14:04 UTC
Message-ID
<CALkWK0mBnG7houMKHDorz3oSm=R7u4Va1s=AepSM0CPY6Gy4cw@mail.gmail.com>
In-Reply-To
<CAMP44s1p-VDMLNhoym5fH3XAn8CWqu2yqGq0mb+55qHOq-r_ww@mail.gmail.com>
Felipe Contreras wrote:
>> Ofcourse they're implementation details.  Even in this very test, I
>> check $dotest/autostash plenty of times.
>
> The more the test relies on implementation details, the worst.
I'm not convinced about this.
>> Then show me how to do it correctly.
>
> Something like this.
Yeah, this is definitely better.  Can you submit this patch?
Previous: Felipe ContrerasNext: Felipe Contreras
Message 6 of 10 in “tests: fix autostash”
  1. tests: fix autostashFelipe Contreras, Jun 7, 2013
  2. Ramkumar RamachandraJun 8, 2013
  3. Felipe ContrerasJun 8, 2013
  4. Ramkumar RamachandraJun 8, 2013
  5. Felipe ContrerasJun 8, 2013
  6. Ramkumar RamachandraJun 8, 2013
  7. Felipe ContrerasJun 8, 2013
  8. Antoine PelisseJun 8, 2013
  9. Ramkumar RamachandraJun 8, 2013
  10. Jonathan NiederJun 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.