git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] tests: add initial bash completion tests

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 13, 2012, 11:56 UTC
Message-ID
<CAMP44s0C=MV_gxsH9Mk9V6Q27E2E=o1nr3HShBFSTyTYC0Tg4w@mail.gmail.com>
In-Reply-To
<20120413111437.GF2164@goldbirke>
2012/4/13 SZEDER Gábor <szeder@ira.uka.de>:
Show 5 quoted lines
> i.e. to set COMP_WORDS and COMP_CWORD in run_completion() and it
> worked.  However, I agree that it feels iffy to mess with a
> shell-specific variable, and I'm afraid that this just happened to
> work on my system, but it might be broken in previous or future bash
> versions.

Yeah, we could explore that possibility later, as _get_comp_words_by_ref is part of the completion, and should be tested as well, otherwise we might be missing some bugs.

However, I wonder if _get_comp_words_by_ref is needed at all. From what I can see it has to do with '--foo=bar' and 'foo:bar' completions, which in fact don't work correctly in zsh (I have patches for zsh to fix this though), but by modifying the code that checks for '--*=*' stuff we might be able to get rid of it, or at least the call to __git_reassemble_comp_words_by_ref. Right?

Cheers.
-- 
Felipe Contreras
Previous: SZEDER GáborNext: Felipe Contreras
Message 12 of 21 in “tests: add initial bash completion tests”
  1. tests: add initial bash completion testsFelipe Contreras, Apr 11, 2012
  2. Junio C HamanoApr 11, 2012
  3. Felipe ContrerasApr 12, 2012
  4. Junio C HamanoApr 12, 2012
  5. Felipe ContrerasApr 12, 2012
  6. Junio C HamanoApr 12, 2012
  7. Junio C HamanoApr 13, 2012
  8. SZEDER GáborApr 13, 2012
  9. SZEDER GáborApr 13, 2012
  10. Felipe ContrerasApr 13, 2012
  11. SZEDER GáborApr 13, 2012
  12. Felipe ContrerasApr 13, 2012
  13. Felipe ContrerasApr 13, 2012
  14. SZEDER GáborApr 13, 2012
  15. Thomas RastApr 13, 2012
  16. Junio C HamanoApr 13, 2012
  17. Felipe ContrerasApr 14, 2012
  18. SZEDER GáborApr 17, 2012
  19. Felipe ContrerasApr 17, 2012
  20. SZEDER GáborApr 17, 2012
  21. tests: add tests for the __gitcomp() completion helper functionSZEDER Gábor, Apr 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.