git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] tests: add initial bash completion tests

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 13, 2012, 19:45 UTC
Message-ID
<7vaa2f2z62.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7vzkag3528.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 7 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Do I need to resend the patch?
>
> Not necessarily.  If you can eyeball what is queued on 'pu' and gave me an
> Ack (or send a replacement with "You stupid, you amended it wrong!") that
> should be sufficient.

Actually, can we have a follow-up patch to add in-code comment before the _get_comp_words_by_ref shell function in t9902 to explain why the test overrides this implementation detail? The script being tested will need to maintain _some_ invariants that is expected by this hack in order to keep the test working (or this hack needs to be updated when the updates to the completion script need to break the invariants), but without any explanation on what the invariants are, it is making it hard to others to update the completion script.

Thanks.
Previous: Junio C HamanoNext: SZEDER Gábor
Message 7 of 21 in “tests: add initial bash completion tests”
  1. tests: add initial bash completion testsFelipe Contreras, Apr 11, 2012
  2. Junio C HamanoApr 11, 2012
  3. Felipe ContrerasApr 12, 2012
  4. Junio C HamanoApr 12, 2012
  5. Felipe ContrerasApr 12, 2012
  6. Junio C HamanoApr 12, 2012
  7. Junio C HamanoApr 13, 2012
  8. SZEDER GáborApr 13, 2012
  9. SZEDER GáborApr 13, 2012
  10. Felipe ContrerasApr 13, 2012
  11. SZEDER GáborApr 13, 2012
  12. Felipe ContrerasApr 13, 2012
  13. Felipe ContrerasApr 13, 2012
  14. SZEDER GáborApr 13, 2012
  15. Thomas RastApr 13, 2012
  16. Junio C HamanoApr 13, 2012
  17. Felipe ContrerasApr 14, 2012
  18. SZEDER GáborApr 17, 2012
  19. Felipe ContrerasApr 17, 2012
  20. SZEDER GáborApr 17, 2012
  21. tests: add tests for the __gitcomp() completion helper functionSZEDER Gábor, Apr 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.