Re: [PATCH v2] tests: add initial bash completion tests

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 12, 2012, 23:26 UTC
Message-ID: <7vzkag3528.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s37znvnw+n3NsFj+ZVuxwPhrordJA0ko0LV9udPS+i3aQ@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 28 quoted lines

> On Thu, Apr 12, 2012 at 8:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> On Thu, Apr 12, 2012 at 12:57 AM, Felipe Contreras
>>> <felipe.contreras@gmail.com> wrote:
>>>
>>>> +test_expect_success 'double dash' '
>>>> +       cat >expected <<-\EOF &&
>>>> +       --paginate
>>>> +       --no-pager
>>>> +       --git-dir=
>>>> +       --bare
>>>> +       --version
>>>> +       --exec-path
>>>> +       --html-path
>>>> +       --work-tree=
>>>> +       --namespace=
>>>> +       --help
>>>> +       EOF
>>>> +       test_completion "git --"
>>>
>>> There's a mistake here ^.
>>
>> Yeah, good eyes!  ... ah, wait, it is your bug ;-)
>
> Not my eyes, further tests =/
>
> Do I need to resend the patch?

Not necessarily. If you can eyeball what is queued on 'pu' and gave me an Ack (or send a replacement with "You stupid, you amended it wrong!") that should be sufficient.

Thanks.