From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Fri, 13 Apr 2012 11:56:08 GMT
Subject: Re: [PATCH v2] tests: add initial bash completion tests
Message-ID: <CAMP44s0C=MV_gxsH9Mk9V6Q27E2E=o1nr3HShBFSTyTYC0Tg4w@mail.gmail.com>
In-Reply-To: <20120413111437.GF2164@goldbirke>

2012/4/13 SZEDER Gábor <szeder@ira.uka.de>:

> i.e. to set COMP_WORDS and COMP_CWORD in run_completion() and it
> worked.  However, I agree that it feels iffy to mess with a
> shell-specific variable, and I'm afraid that this just happened to
> work on my system, but it might be broken in previous or future bash
> versions.

Yeah, we could explore that possibility later, as
_get_comp_words_by_ref is part of the completion, and should be tested
as well, otherwise we might be missing some bugs.

However, I wonder if _get_comp_words_by_ref is needed at all. From
what I can see it has to do with '--foo=bar' and 'foo:bar'
completions, which in fact don't work correctly in zsh (I have patches
for zsh to fix this though), but by modifying the code that checks for
'--*=*' stuff we might be able to get rid of it, or at least the call
to __git_reassemble_comp_words_by_ref. Right?

Cheers.

-- 
Felipe Contreras