Re: [PATCH 04/15] t1007 (hash-object): fix && chaining
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Dec 8, 2011, 04:42 UTC
- Message-ID
- <CALkWK0nDqbzkbsCqeqQ4ywvnR-t1KapxBZsSWJLu+1K+UDQGzg@mail.gmail.com>
- In-Reply-To
- <20111207214716.GA2911@elie.hsd1.il.comcast.net>
Hi Jonathan,
Jonathan Nieder wrote:
Show 6 quoted lines
> Ramkumar Ramachandra wrote: > [...] > > IMHO if the patches are only being sent to me, Junio, and the > mailing list (and not cc-ed to different people), then there's no > reason to split them up when they have the same topic.
Right. I'll re-roll with similar patches squashed together -- it's easier to review and fixup in this form.
Show 15 quoted lines
>> --- a/t/t1007-hash-object.sh >> +++ b/t/t1007-hash-object.sh >> @@ -154,13 +154,13 @@ test_expect_success 'check that --no-filters option works with --stdin-paths' ' >> pop_repo >> >> for args in "-w --stdin" "--stdin -w"; do >> - push_repo >> + push_repo && >> >> test_expect_success "hash from stdin and write to database ($args)" ' >> test $example_sha1 = $(git hash-object $args < example) >> - ' >> + ' && > > I don't see how this would have any effect. Is it intended?
Oops, looks like I was in a bit of a rush. Good catch.
-- Ram