Re: [PATCH 04/15] t1007 (hash-object): fix && chaining

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 7, 2011, 21:47 UTC
Message-ID: <20111207214716.GA2911@elie.hsd1.il.comcast.net>
In-Reply-To: <1323286611-4806-5-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>

I think there's room for at least one line of description about why one would want to do this.

IMHO if the patches are only being sent to me, Junio, and the mailing list (and not cc-ed to different people), then there's no reason to split them up when they have the same topic.

Aside from that, patches 1-3 look good.  Now for this one:

[...]

Show 13 quoted lines

> --- a/t/t1007-hash-object.sh
> +++ b/t/t1007-hash-object.sh
> @@ -154,13 +154,13 @@ test_expect_success 'check that --no-filters option works with --stdin-paths' '
>  pop_repo
>  
>  for args in "-w --stdin" "--stdin -w"; do
> -	push_repo
> +	push_repo &&
>  
>  	test_expect_success "hash from stdin and write to database ($args)" '
>  		test $example_sha1 = $(git hash-object $args < example)
> -	'
> +	' &&

I don't see how this would have any effect.  Is it intended?