Re: [PATCH 08/15] t3200 (branch): fix && chaining

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 7, 2011, 21:55 UTC
Message-ID: <20111207215509.GC2911@elie.hsd1.il.comcast.net>
In-Reply-To: <1323286611-4806-9-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

Show 9 quoted lines

> --- a/t/t3200-branch.sh
> +++ b/t/t3200-branch.sh
> @@ -22,7 +22,7 @@ test_expect_success \
>  
>  test_expect_success \
>      'git branch --help should not have created a bogus branch' '
> -     git branch --help </dev/null >/dev/null 2>/dev/null;
> +     git branch --help </dev/null >/dev/null 2>/dev/null &&
>       test_path_is_missing .git/refs/heads/--help

Won't this break when running tests for the first time, before the git manpages are installed?

Show 9 quoted lines

>  '
>  
> @@ -88,7 +88,7 @@ test_expect_success \
>  test_expect_success \
>      'git branch -m n/n n should work' \
>         'git branch -l n/n &&
> -        git branch -m n/n n
> +        git branch -m n/n n &&
>  	test_path_is_file .git/logs/refs/heads/n'

Good catch.