Re: What's cooking in git.git (Dec 2011, #02; Mon, 5)

From: Jeff King <peff@peff.net>
Date: Dec 6, 2011, 05:52 UTC
Message-ID: <20111206055239.GA20671@sigill.intra.peff.net>
In-Reply-To: <7v8vmqi98f.fsf@alter.siamese.dyndns.org>

On Mon, Dec 05, 2011 at 09:01:52PM -0800, Junio C Hamano wrote:

Show 23 quoted lines

> * jk/credentials (2011-11-28) 20 commits
>  - fixup! 034c066e
>  - compat/getpass: add a /dev/tty implementation
>  - credential: use git_prompt instead of git_getpass
>  - prompt: add PROMPT_ECHO flag
>  - stub out getpass_echo function
>  - refactor git_getpass into generic prompt function
>  - move git_getpass to its own source file
>  - t: add test harness for external credential helpers
>  - credentials: add "store" helper
>  - strbuf: add strbuf_add*_urlencode
>  - credentials: add "cache" helper
>  - docs: end-user documentation for the credential subsystem
>  - credential: make relevance of http path configurable
>  - credential: add credential.*.username
>  - credential: apply helper config
>  - http: use credential API to get passwords
>  - credential: add function for parsing url components
>  - introduce credentials API
>  - t5550: fix typo
>  - test-lib: add test_config_global variant
> 
> Expecting a reroll?

Yes, I have a re-roll ready. I was holding back to see if some of the helper authors might comment, but got nothing. Perhaps the new version will spur some interest.

Also, let's drop the top git_getpass bits from the topic for now (they will not be part of my rebase). They are a separate topic that can go on top, but I think there was some question from Erik of whether we should simply roll our own getpass().

> * jk/upload-archive-use-start-command (2011-11-21) 1 commit
>  - upload-archive: use start_command instead of fork
> 
> What's the status of this one?

I think what you have in pu is good, but of course I didn't actually test it on Windows. Erik?

Show 9 quoted lines

> * jk/maint-1.6.2-upload-archive (2011-11-21) 1 commit
>  - archive: don't let remote clients get unreachable commits
>  (this branch is used by jk/maint-upload-archive.)
> 
> * jk/maint-upload-archive (2011-11-21) 1 commit
>  - Merge branch 'jk/maint-1.6.2-upload-archive' into jk/maint-upload-archive
>  (this branch uses jk/maint-1.6.2-upload-archive.)
> 
> Will merge to 'next' after taking another look.

Thanks. I also have some followup patches to re-loosen to at least trees reachable from refs. Do you want to leave the tightening to the maint track, and then consider the re-loosening for master?

-Peff