Re: [PATCH v2 6/7] rebase: write better reflog messages

From

Ramkumar Ramachandra <artagnon@gmail.com>

Date

Jun 19, 2013, 06:09 UTC

Message-ID

<CALkWK0mMLPHp=OcWAPW5g3Eb7CBt42dtqkDwpQp69tKwLNYe0Q@mail.gmail.com>

In-Reply-To

<51C1442A.2010904@viscovery.net>

Johannes Sixt wrote:

> I haven't followed the topic closely, but I wonder why there are so many
> explicit assignments to GIT_REFLOG_ACTION. Is calling set_reflog_action
> (defined in git-sh-setup) the wrong thing to do?

Does this answer your question?

set_reflog_action() {
	if [ -z "${GIT_REFLOG_ACTION:+set}" ]
	then
		GIT_REFLOG_ACTION="$*"
		export GIT_REFLOG_ACTION
	fi
}