Re: [PATCH v2 6/7] rebase: write better reflog messages

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jun 19, 2013, 05:39 UTC
Message-ID: <51C1442A.2010904@viscovery.net>
In-Reply-To: <1371581737-10013-7-git-send-email-artagnon@gmail.com>

Am 6/18/2013 20:55, schrieb Ramkumar Ramachandra:

Show 10 quoted lines

> Now that the "checkout" invoked internally from "rebase" knows to honor
> GIT_REFLOG_ACTION, we can start to use it to write a better reflog
> message when "rebase anotherbranch", "rebase --onto branch",
> etc. internally checks out the new fork point.  We will write:
> 
>   rebase: checkout master
> 
> instead of the old
> 
>   rebase

Show 9 quoted lines

> diff --git a/git-rebase--am.sh b/git-rebase--am.sh
> index 34e3102..69fae7a 100644
> --- a/git-rebase--am.sh
> +++ b/git-rebase--am.sh
> @@ -5,11 +5,13 @@
>  
>  case "$action" in
>  continue)
> +	GIT_REFLOG_ACTION="$base_reflog_action"

I haven't followed the topic closely, but I wonder why there are so many explicit assignments to GIT_REFLOG_ACTION. Is calling set_reflog_action (defined in git-sh-setup) the wrong thing to do?

-- Hannes