Re: [PATCH v2 6/7] rebase: write better reflog messages

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jun 19, 2013, 06:24 UTC
Message-ID: <51C14E93.5000707@viscovery.net>
In-Reply-To: <CALkWK0mMLPHp=OcWAPW5g3Eb7CBt42dtqkDwpQp69tKwLNYe0Q@mail.gmail.com>

Am 6/19/2013 8:09, schrieb Ramkumar Ramachandra:

Show 14 quoted lines

> Johannes Sixt wrote:
>> I haven't followed the topic closely, but I wonder why there are so many
>> explicit assignments to GIT_REFLOG_ACTION. Is calling set_reflog_action
>> (defined in git-sh-setup) the wrong thing to do?
> 
> Does this answer your question?
> 
> set_reflog_action() {
> 	if [ -z "${GIT_REFLOG_ACTION:+set}" ]
> 	then
> 		GIT_REFLOG_ACTION="$*"
> 		export GIT_REFLOG_ACTION
> 	fi
> }

Please don't state the obvious, that does not help. Of course, this does not answer my question. I was rather hinting that it may be wrong to set GIT_REFLOG_ACTION explicitly.

I thought that the convention is not to modify GIT_REFLOG_ACTION if it is already set. set_reflog_action does just that.

-- Hannes