Re: [PATCH 1/8] remote-bzr: fix export of utf-8 authors

From: Antoine Pelisse <apelisse@gmail.com>
Date: Aug 28, 2013, 20:54 UTC
Message-ID: <CALWbr2xi1+EKHry4GRwLv=SwRUsaTKLQc6RUfuPKEre4pcpaFg@mail.gmail.com>
In-Reply-To: <CAMP44s2bu9gUE=McYq1prhjC3O2CRj1W_Yc+-CjTkk6Gc3JFTw@mail.gmail.com>

On Wed, Aug 28, 2013 at 10:48 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 24 quoted lines

> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> +     echo greg >> content &&
>>> +     git add content &&
>>> +     git commit -m one
>>
>> test_commit would make it shorter.
>
> And it would make it inconsistent with the rest of the script.
>
>>> +     bzr log | grep "^committer: " > ../actual
>>> +     ) &&
>>> +
>>> +     echo "committer: Grégoire <committer@example.com>" > expected &&
>>
>> Git's source code usually says >../actual and >expected, without space
>> after '>'.
>
> Not that usually:
>
> % git grep ' > ' t/*.sh | wc -l
> 1943

There are many false positive in that count.

As in this one: $ git grep ' >[^ ]' -- t/*.sh | wc -l 10354