Re: [PATCH 1/8] remote-bzr: fix export of utf-8 authors

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 28, 2013, 21:58 UTC
Message-ID: <xmqq7gf58okw.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpqy57l4jcx.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 19 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>>
>>>> +     bzr log | grep "^committer: " > ../actual
>>>> +     ) &&
>>>> +
>>>> +     echo "committer: Grégoire <committer@example.com>" > expected &&
>>>
>>> Git's source code usually says >../actual and >expected, without space
>>> after '>'.
>>
>> Not that usually:
>>
>> % git grep ' > ' t/*.sh | wc -l
>> 1943
>
> Do I really need to quote the paragraph in CodingGuidelines?

Existing violations are not an excuse to make things worse by adding more. I think with these comments we can expect a reroll coming, and it should be trivial for any contributor to fix it while at it.