From: Antoine Pelisse Date: Wed, 28 Aug 2013 20:54:41 GMT Subject: Re: [PATCH 1/8] remote-bzr: fix export of utf-8 authors Message-ID: In-Reply-To: On Wed, Aug 28, 2013 at 10:48 PM, Felipe Contreras wrote: > On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy > wrote: >> Felipe Contreras writes: >> >>> + echo greg >> content && >>> + git add content && >>> + git commit -m one >> >> test_commit would make it shorter. > > And it would make it inconsistent with the rest of the script. > >>> + bzr log | grep "^committer: " > ../actual >>> + ) && >>> + >>> + echo "committer: Grégoire " > expected && >> >> Git's source code usually says >../actual and >expected, without space >> after '>'. > > Not that usually: > > % git grep ' > ' t/*.sh | wc -l > 1943 There are many false positive in that count. As in this one: $ git grep ' >[^ ]' -- t/*.sh | wc -l 10354