Re: Re* [PATCH 1/8] remote-bzr: fix export of utf-8 authors

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 29, 2013, 21:42 UTC
Message-ID: <xmqq8uzk2mzb.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CALWbr2xe8jC4QnLTEOWJX_kn_FcQjSafPn=NKd3UsK9fO5f=_g@mail.gmail.com>

Antoine Pelisse <apelisse@gmail.com> writes:

Show 25 quoted lines

> On Thu, Aug 29, 2013 at 11:24 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> -- >8 --
>> Subject: [PATCH 9/8] contrib/remote-helpers: style updates for test scripts
>>
>> During the review of the main series it was noticed that these test
>> scripts can use updates to conform to our coding style better, but
>> fixing the style should be done in a patch separate from the main
>> series.
>>
>> This updates the test-*.sh scripts only for styles:
>>
>>  * We do not leave SP between a redirection operator and the
>>    filename;
>>
>>  * We change line before "then", "do", etc. rather than terminating
>>    the condition for "if"/"while" and list for "for" with a
>>    semicolon;
>>
>>  * When HERE document does not use any expansion, we quote the end
>>    marker (e.g. "cat <<\EOF" not "cat <<EOF") to signal the readers
>>    that there is no funny substitution to worry about when reading
>>    the code.
>
> May I ask what pattern you used to replace all these or if you went
> through manually ?

"M-x query-replace" from "> " to ">" with manual inspection. I never use full automation myself, as I do not trust that I am careful enough and it is prone to unexpected changes that I can easily miss.