Re: [PATCH 18/18] signed push: final protocol update
- From
Shawn Pearce <spearce@spearce.org>
- Date
- Aug 21, 2014, 19:28 UTC
- Message-ID
- <CAJo=hJuToRQDTkccV9BfVbs1YnjCrr2iPrG-HmTbJ=ds4r6MzA@mail.gmail.com>
- In-Reply-To
- <1408485987-3590-19-git-send-email-gitster@pobox.com>
On Tue, Aug 19, 2014 at 3:06 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> + push-cert = PKT-LINE("push-cert" NUL capability-list LF)Haha. NUL. I love our wire protocol.
Show 5 quoted lines
> + PKT-LINE("certificate version 0.1" LF)
> + PKT-LINE("pusher" ident LF)
> + PKT-LINE(LF)
> + *PKT-LINE(command LF)
> + *PKT-LINE(GPG signature lines LF)Should we include the URL as part of this certificate?
Perhaps the pusher means to sign the master branch of experimental tree, but not their trunk tree?