Re: [PATCH v2 08/20] remote-curl: accept empty line as terminator
Heya,
On Mon, Jun 20, 2011 at 00:42, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 11 quoted lines
> Thanks. I wonder if that first "if" should be something like
>
> if (strbuf_getline(&buf, stdin, '\n') == EOF) {
> if (ferror(stdin))
> fprintf(stderr, "Error reading command stream\n");
> else
> fprintf(stderr, "Unexpected end of command stream\n");
> return 1;
> }
>
> to catch I/O errors (e.g., the transport-helper exiting early).Good idea, done. Tests still pass too ;).
--
Cheers,
Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com>