git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 07/20] git_remote_helpers: push all refs during a non-local export

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Jun 19, 2011, 15:18 UTC
Message-ID
<1308496725-22329-8-git-send-email-srabbelier@gmail.com>
In-Reply-To
<1308496725-22329-1-git-send-email-srabbelier@gmail.com>
From: Jeff King <peff@peff.net>

When a remote helper exports to a non-local git repo, the steps are roughly:

  1. fast-export into a local staging area; the set of
     interesting refs is defined by what is in the fast-export
     stream
  2. git push from the staging area to the non-local repo

In the second step, we should explicitly push all refs, not just matching ones. This will let us push refs that do not yet exist in the remote repo.

This does not deal with forced (not-fast-forward) pushes.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
---
  Added last line to the commit message.
 git_remote_helpers/git/non_local.py |    2 +-
 t/t5800-remote-helpers.sh           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git_remote_helpers/git/non_local.py b/git_remote_helpers/git/non_local.py
index f27389b..c53e074 100644
--- a/git_remote_helpers/git/non_local.py
+++ b/git_remote_helpers/git/non_local.py
@@ -63,7 +63,7 @@ class NonLocalGit(object):
         if not os.path.exists(path):
             die("could not find repo at %s", path)
 
-        args = ["git", "--git-dir=" + path, "push", "--quiet", self.repo.gitpath]
+        args = ["git", "--git-dir=" + path, "push", "--quiet", self.repo.gitpath, "--all"]
         child = subprocess.Popen(args)
         if child.wait() != 0:
             raise CalledProcessError
diff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh
index ceb0010..12f471c 100755
--- a/t/t5800-remote-helpers.sh
+++ b/t/t5800-remote-helpers.sh
@@ -115,7 +115,7 @@ test_expect_success 'push when remote has extra refs' '
 	compare_refs clone master server master
 '
 
-test_expect_failure 'push new branch by name' '
+test_expect_success 'push new branch by name' '
 	(cd clone &&
 	 git checkout -b new-name  &&
 	 echo content >>file &&

-- 
1.7.5.1.292.g728120
Previous: Sverre RabbelierNext: Sverre Rabbelier
Message 10 of 44 in “remote-helper improvements”
  1. 00/20 remote-helper improvementsSverre Rabbelier, Jun 19, 2011
  2. 01/20 transport-helper: fix minor leak in push_refs_with_exportSverre Rabbelier, Jun 19, 2011
  3. 02/20 t5800: factor out some ref testsSverre Rabbelier, Jun 19, 2011
  4. 03/20 t5800: use skip_all instead of prereqSverre Rabbelier, Jun 19, 2011
  5. 04/20 t5800: document some non-functional parts of remote helpersSverre Rabbelier, Jun 19, 2011
  6. Jonathan NiederJun 19, 2011
  7. Sverre RabbelierJul 4, 2011
  8. 05/20 teach remote-testgit to import non-HEAD refsSverre Rabbelier, Jun 19, 2011
  9. 06/20 transport-helper: don't feed bogus refs to export pushSverre Rabbelier, Jun 19, 2011
  10. 07/20 git_remote_helpers: push all refs during a non-local exportSverre Rabbelier, Jun 19, 2011
  11. 08/20 remote-curl: accept empty line as terminatorSverre Rabbelier, Jun 19, 2011
  12. Jonathan NiederJun 19, 2011
  13. Sverre RabbelierJul 4, 2011
  14. 08/20 remote-curl: accept empty line as terminatorDmitry Ivankov, Jun 20, 2011
  15. Jonathan NiederJun 20, 2011
  16. Junio C HamanoJun 20, 2011
  17. 09/20 git-remote-testgit: only push for non-local repositoriesSverre Rabbelier, Jun 19, 2011
  18. 10/20 git-remote-testgit: fix error handlingSverre Rabbelier, Jun 19, 2011
  19. Jonathan NiederJun 19, 2011
  20. Brandon CaseyJun 20, 2011
  21. Sverre RabbelierJun 20, 2011
  22. 11/20 fast-import: introduce 'done' commandSverre Rabbelier, Jun 19, 2011
  23. 12/20 fast-export: support done featureSverre Rabbelier, Jun 19, 2011
  24. 13/20 transport-helper: factor out push_update_refs_statusSverre Rabbelier, Jun 19, 2011
  25. 14/20 transport-helper: check status code of finish_commandSverre Rabbelier, Jun 19, 2011
  26. 15/20 transport-helper: use the new done feature where possibleSverre Rabbelier, Jun 19, 2011
  27. Jonathan NiederJun 20, 2011
  28. Junio C HamanoJun 20, 2011
  29. Sverre RabbelierJul 4, 2011
  30. 16/20 transport-helper: update ref status after push with exportSverre Rabbelier, Jun 19, 2011
  31. Jonathan NiederJun 19, 2011
  32. Junio C HamanoJun 21, 2011
  33. Sverre RabbelierJun 21, 2011
  34. 17/20 transport-helper: change import semanticsSverre Rabbelier, Jun 19, 2011
  35. Jonathan NiederJun 19, 2011
  36. Sverre RabbelierJul 4, 2011
  37. Jonathan NiederJul 4, 2011
  38. Sverre RabbelierJul 4, 2011
  39. Jonathan NiederJul 4, 2011
  40. 18/20 transport-helper: export is no longer always the last commandSverre Rabbelier, Jun 19, 2011
  41. 19/20 transport-helper: Use capname for gitdir capability tooSverre Rabbelier, Jun 19, 2011
  42. 20/20 transport-helper: implement marks location as capabilitySverre Rabbelier, Jun 19, 2011
  43. Jonathan NiederJun 20, 2011
  44. Sverre RabbelierJul 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.