[PATCH v2 18/20] transport-helper: export is no longer always the last command
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Jun 19, 2011, 15:18 UTC
- Message-ID
- <1308496725-22329-19-git-send-email-srabbelier@gmail.com>
- In-Reply-To
- <1308496725-22329-1-git-send-email-srabbelier@gmail.com>
The trailing \n in the protocol signals the helper that the connection is about to close, allowing it to do whatever cleanup neccesary.
Previously, the connection would already be closed by the time the trailing \n was to be written. Now that the remote-helper protocol uses the new done command in its fast-import streams, this is no longer the case and we can safely write the trailing \n.
Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com> ---
Updated commit message.
transport-helper.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c index c089928..f78b670 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -762,7 +762,6 @@ static int push_refs_with_export(struct transport *transport, export_marks, import_marks, &revlist_args)) die("Couldn't run fast-export"); - data->no_disconnect_req = 1; if (finish_command(&exporter)) die("Error while running fast-export"); push_update_refs_status(data, remote_refs);
-- 1.7.5.1.292.g728120