Re: [PATCH 2/8] strbuf.c: reintroduce get_pwd_cwd() (with strbuf_ prefix)
- From
Stefan Beller <sbeller@google.com>
- Date
- Mar 28, 2018, 18:02 UTC
- Message-ID
- <CAGZ79kbofCd+8iscOFUNHTfQ2Y1cUDUjp5kOQQr_b1uPgPC2Eg@mail.gmail.com>
- In-Reply-To
- <20180328175537.17450-3-pclouds@gmail.com>
On Wed, Mar 28, 2018 at 10:55 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
Show 5 quoted lines
> +/** > + * Return the current directory, fall back to $PWD if the > + * current directory does not exist. > + */ > +extern void strbuf_get_pwd_cwd(struct strbuf *sb);
Please see 89a9f2c862 (CodingGuidelines: mention "static" and "extern", 2018-02-08) and drop the extern if you need to reroll.
Thanks, Stefan