Re: [PATCH v2 2/5] trace.c: export trace_setup_key

From: Jeff King <peff@peff.net>
Date: Mar 30, 2018, 19:54 UTC
Message-ID: <20180330195436.GA14217@sigill.intra.peff.net>
In-Reply-To: <xmqq4lkx2vhh.fsf@gitster-ct.c.googlers.com>

On Fri, Mar 30, 2018 at 12:50:50PM -0700, Junio C Hamano wrote:

Show 17 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > On Fri, Mar 30, 2018 at 12:46:26PM -0700, Junio C Hamano wrote:
> >
> >> Jeff King <peff@peff.net> writes:
> >> 
> >> > From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> >> >
> >> > This is so that we can print traces based on this key outside trace.c.
> >> 
> >> "this key" meaning...?  GIT_TRACE_SETUP?
> >
> > I think "based on trace_setup_key".
> >
> > -Peff
> 
> Yeah, I read, but did not pay enough attention to, the subject X-<.

To be fair, one of our guidelines is that the commit message should not overly rely on the subject line. Though I am certainly guilty of starting many a message with "This".

Perhaps:

  The setup-tracing code is static-local to trace.c. In preparation for
  new GIT_TRACE_SETUP code outside of trace.c, let's make the trace_key
  globally available.

would be a better commit message.

-Peff