Re: [PATCH 2/8] strbuf.c: reintroduce get_pwd_cwd() (with strbuf_ prefix)

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 28, 2018, 18:05 UTC
Message-ID: <CACsJy8D6h_t0LTD6ML8o4imEaU7vqxZJyzaBU6McCfVqWOQkWA@mail.gmail.com>
In-Reply-To: <CAGZ79kbofCd+8iscOFUNHTfQ2Y1cUDUjp5kOQQr_b1uPgPC2Eg@mail.gmail.com>

On Wed, Mar 28, 2018 at 8:02 PM, Stefan Beller <sbeller@google.com> wrote:

Show 10 quoted lines

> On Wed, Mar 28, 2018 at 10:55 AM, Nguyễn Thái Ngọc Duy
> <pclouds@gmail.com> wrote:
>> +/**
>> + * Return the current directory, fall back to $PWD if the
>> + * current directory does not exist.
>> + */
>> +extern void strbuf_get_pwd_cwd(struct strbuf *sb);
>
> Please see 89a9f2c862 (CodingGuidelines: mention "static" and "extern",
> 2018-02-08) and drop the extern if you need to reroll.

I'm aware (and in favor) of that actually. But this whole strbuf.h uses extern. Either I had to delete all extern first, or go with old style and maybe do the whole deletion later. I chose the former. Maybe be I'll delete all "extern" as a prep patch.

-- 
Duy