Re: [PATCH 00/27] sb/object-store updates

From: Stefan Beller <sbeller@google.com>
Date: Mar 26, 2018, 17:45 UTC
Message-ID: <CAGZ79kbkc2d-EHDTWP1GvCU62=ogZbP0ffxOHZamdQK+3h1yJw@mail.gmail.com>
In-Reply-To: <20180324053144.GA11420@duynguyen.home>

On Fri, Mar 23, 2018 at 10:31 PM Duy Nguyen <pclouds@gmail.com> wrote:

> I got too excited when searching and replacing. Here's the fixup
> patch.

Thanks for picking up the series that I left unattended over the last weeks. I have reviewed nd/remove-ignore-env-field as well as sb/object-store as currently queued and found them well done.

Thanks for driving this when I was away!

With the fixup patch, both series are
Reviewed-by: Stefan Beller <sbeller@google.com>
(No need to apply that as it already looks funny to have
3-5 sign offs including mine)

With these 2 series reviewed, I'll continue reviewing sb/pack-files-in-repository and the rest of my mail box.

Thanks, Stefan

> -- 8< --
> Subject: [PATCH] fixup! object-store: move packed_git and packed_git_mru

to

>   object store

> ---
>   packfile.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Show 5 quoted lines

> diff --git a/packfile.c b/packfile.c
> index 63c89ee31a..0906b8f741 100644
> --- a/packfile.c
> +++ b/packfile.c
> @@ -1937,7 +1937,7 @@ static int add_promisor_object(const struct

object_id *oid,

Show 9 quoted lines

>          /*
>           * If this is a tree, commit, or tag, the objects it refers
> -        * to are also promisor objects-> (Blobs refer to no objects->)
> +        * to are also promisor objects. (Blobs refer to no objects.)
>           */
>          if (obj->type == OBJ_TREE) {
>                  struct tree *tree = (struct tree *)obj;
> --
> 2.17.0.rc0.348.gd5a49e0b6f

> -- 8< --