Re: [PATCH 1/1] repository.h: add comment and clarify repo_set_gitdir
- From
Stefan Beller <sbeller@google.com>
- Date
- Mar 26, 2018, 21:04 UTC
- Message-ID
- <CAGZ79ka0ptbwHU0Ym7aGm86o+YG27goHR6iS3uf5yUkj0Uj15w@mail.gmail.com>
- In-Reply-To
- <20180323155523.22269-2-pclouds@gmail.com>
On Fri, Mar 23, 2018 at 8:55 AM Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> The argument name "optional" may mislead the reader to think this > option could be NULL. But it can't be. While at there, document a bit > more about struct set_gitdir_args.
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Reviewed-by: Stefan Beller <sbeller@google.com>