git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/27] sb/object-store updates

From
BWBrandon Williams <bmwill@google.com>
Date
Mar 23, 2018, 18:50 UTC
Message-ID
<20180323185055.GD243756@google.com>
In-Reply-To
<20180323183550.GB243756@google.com>
On 03/23, Brandon Williams wrote:
Show 13 quoted lines
> On 03/23, Nguyễn Thái Ngọc Duy wrote:
> > I think I have addressed all comments I've received so far. What I
> > decided not to do, I have responded individually. One comment I did
> > not respond nor do is the approximate thing, which could be done
> > later.
> > 
> > Interdiff is big due to the "objects." to "objects->" conversion
> > (blame Brandon for his suggestion, don't blame me :D)
> 
> Haha, I'm guessing you prefer having a pointer too then? :P 
> 
> The interdiff looks good, though I'll set some time aside today to go
> through the series as a whole again.

Had some more time than I thought; this series looks good! Thanks for take the time to keep this rolling. Hopefully we can see this merged soon :)

-- 
Brandon Williams
Previous: Brandon WilliamsNext: Junio C Hamano
Message 114 of 135 in “Re: [PATCH 00/11] Moving global state into the repository object (part 2)”
  1. Duy NguyenMar 3, 2018
  2. 00/44 reroll nd/remove-ignore-env.. sb/object-store and sb/packfiles..Nguyễn Thái Ngọc Duy, Mar 3, 2018
  3. 01/44 repository: initialize the_repository in main()Nguyễn Thái Ngọc Duy, Mar 3, 2018
  4. Brandon WilliamsMar 21, 2018
  5. 02/44 repository.c: move env-related setup code back to environment.cNguyễn Thái Ngọc Duy, Mar 3, 2018
  6. Jonathan TanMar 19, 2018
  7. Duy NguyenMar 19, 2018
  8. Brandon WilliamsMar 21, 2018
  9. 03/44 repository.c: delete dead functionsNguyễn Thái Ngọc Duy, Mar 3, 2018
  10. Brandon WilliamsMar 21, 2018
  11. 04/44 sha1_file.c: move delayed getenv(altdb) back to setup_git_env()Nguyễn Thái Ngọc Duy, Mar 3, 2018
  12. Brandon WilliamsMar 21, 2018
  13. 05/44 repository: delete ignore_env memberNguyễn Thái Ngọc Duy, Mar 3, 2018
  14. Brandon WilliamsMar 21, 2018
  15. 06/44 repository: introduce raw object store fieldNguyễn Thái Ngọc Duy, Mar 3, 2018
  16. Eric SunshineMar 4, 2018
  17. Brandon WilliamsMar 21, 2018
  18. 07/44 object-store: migrate alternates struct and functions from cache.hNguyễn Thái Ngọc Duy, Mar 3, 2018
  19. 08/44 object-store: move alt_odb_list and alt_odb_tail to object storeNguyễn Thái Ngọc Duy, Mar 3, 2018
  20. 09/44 object-store: free alt_odb_listNguyễn Thái Ngọc Duy, Mar 3, 2018
  21. Eric SunshineMar 4, 2018
  22. Duy NguyenMar 5, 2018
  23. Brandon WilliamsMar 21, 2018
  24. 10/44 object-store: move packed_git and packed_git_mru to object storeNguyễn Thái Ngọc Duy, Mar 3, 2018
  25. Jonathan TanMar 19, 2018
  26. Duy NguyenMar 23, 2018
  27. Brandon WilliamsMar 21, 2018
  28. Duy NguyenMar 23, 2018
  29. Duy NguyenMar 23, 2018
  30. Brandon WilliamsMar 23, 2018
  31. 11/44 object-store: close all packs upon clearing the object storeNguyễn Thái Ngọc Duy, Mar 3, 2018
  32. Brandon WilliamsMar 21, 2018
  33. 12/44 pack: move prepare_packed_git_run_once to object storeNguyễn Thái Ngọc Duy, Mar 3, 2018
  34. Brandon WilliamsMar 21, 2018
  35. 13/44 pack: move approximate object count to object storeNguyễn Thái Ngọc Duy, Mar 3, 2018
  36. Eric SunshineMar 4, 2018
  37. Duy NguyenMar 4, 2018
  38. Brandon WilliamsMar 21, 2018
  39. 14/44 sha1_file: add raw_object_store argument to alt_odb_usableNguyễn Thái Ngọc Duy, Mar 3, 2018
  40. 15/44 sha1_file: add repository argument to link_alt_odb_entryNguyễn Thái Ngọc Duy, Mar 3, 2018
  41. 16/44 sha1_file: add repository argument to read_info_alternatesNguyễn Thái Ngọc Duy, Mar 3, 2018
  42. 17/44 sha1_file: add repository argument to link_alt_odb_entriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  43. 18/44 sha1_file: add repository argument to prepare_alt_odbNguyễn Thái Ngọc Duy, Mar 3, 2018
  44. 19/44 sha1_file: allow link_alt_odb_entries to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  45. Brandon WilliamsMar 21, 2018
  46. 20/44 sha1_file: allow prepare_alt_odb to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  47. 21/44 sha1_file: add repository argument to sha1_file_nameNguyễn Thái Ngọc Duy, Mar 3, 2018
  48. 22/44 sha1_file: add repository argument to stat_sha1_fileNguyễn Thái Ngọc Duy, Mar 3, 2018
  49. 23/44 sha1_file: add repository argument to open_sha1_fileNguyễn Thái Ngọc Duy, Mar 3, 2018
  50. 24/44 sha1_file: add repository argument to map_sha1_file_1Nguyễn Thái Ngọc Duy, Mar 3, 2018
  51. 25/44 sha1_file: add repository argument to map_sha1_fileNguyễn Thái Ngọc Duy, Mar 3, 2018
  52. 26/44 sha1_file: add repository argument to sha1_loose_object_infoNguyễn Thái Ngọc Duy, Mar 3, 2018
  53. 27/44 sha1_file: allow sha1_file_name to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  54. 28/44 sha1_file: allow stat_sha1_file to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  55. 29/44 sha1_file: allow open_sha1_file to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  56. 30/44 sha1_file: allow map_sha1_file_1 to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  57. 31/44 sha1_file: allow map_sha1_file to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  58. 32/44 sha1_file: allow sha1_loose_object_info to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  59. Brandon WilliamsMar 21, 2018
  60. 35/44 packfile: allow install_packed_git to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  61. 34/44 packfile: allow rearrange_packed_git to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  62. 36/44 packfile: add repository argument to prepare_packed_git_oneNguyễn Thái Ngọc Duy, Mar 3, 2018
  63. 37/44 packfile: add repository argument to prepare_packed_gitNguyễn Thái Ngọc Duy, Mar 3, 2018
  64. Eric SunshineMar 4, 2018
  65. 38/44 packfile: add repository argument to reprepare_packed_gitNguyễn Thái Ngọc Duy, Mar 3, 2018
  66. 39/44 packfile: allow prepare_packed_git_one to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  67. Jonathan TanMar 19, 2018
  68. 33/44 packfile: allow prepare_packed_git_mru to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  69. 40/44 packfile: allow prepare_packed_git to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  70. Brandon WilliamsMar 21, 2018
  71. Junio C HamanoMar 22, 2018
  72. 41/44 packfile: allow reprepare_packed_git to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  73. 42/44 packfile: add repository argument to find_pack_entryNguyễn Thái Ngọc Duy, Mar 3, 2018
  74. 43/44 packfile: allow find_pack_entry to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 3, 2018
  75. 44/44 packfile: keep prepare_packed_git() privateNguyễn Thái Ngọc Duy, Mar 3, 2018
  76. Jonathan TanMar 19, 2018
  77. Brandon WilliamsMar 21, 2018
  78. Junio C HamanoMar 5, 2018
  79. Brandon WilliamsMar 21, 2018
  80. 0/1 nd/remove-ignore-env-field updatesNguyễn Thái Ngọc Duy, Mar 23, 2018
  81. 1/1 repository.h: add comment and clarify repo_set_gitdirNguyễn Thái Ngọc Duy, Mar 23, 2018
  82. Stefan BellerMar 26, 2018
  83. Stefan BellerMar 26, 2018
  84. 00/27 sb/object-store updatesNguyễn Thái Ngọc Duy, Mar 23, 2018
  85. 04/27 object-store: free alt_odb_listNguyễn Thái Ngọc Duy, Mar 23, 2018
  86. Brandon WilliamsMar 23, 2018
  87. 02/27 object-store: migrate alternates struct and functions from cache.hNguyễn Thái Ngọc Duy, Mar 23, 2018
  88. 03/27 object-store: move alt_odb_list and alt_odb_tail to object storeNguyễn Thái Ngọc Duy, Mar 23, 2018
  89. 10/27 sha1_file: add repository argument to link_alt_odb_entryNguyễn Thái Ngọc Duy, Mar 23, 2018
  90. 17/27 sha1_file: add repository argument to stat_sha1_fileNguyễn Thái Ngọc Duy, Mar 23, 2018
  91. 20/27 sha1_file: add repository argument to map_sha1_fileNguyễn Thái Ngọc Duy, Mar 23, 2018
  92. 22/27 sha1_file: allow sha1_file_name to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  93. 27/27 sha1_file: allow sha1_loose_object_info to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  94. 23/27 sha1_file: allow stat_sha1_file to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  95. 14/27 sha1_file: allow link_alt_odb_entries to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  96. 26/27 sha1_file: allow map_sha1_file to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  97. 16/27 sha1_file: add repository argument to sha1_file_nameNguyễn Thái Ngọc Duy, Mar 23, 2018
  98. 21/27 sha1_file: add repository argument to sha1_loose_object_infoNguyễn Thái Ngọc Duy, Mar 23, 2018
  99. 24/27 sha1_file: allow open_sha1_file to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  100. 25/27 sha1_file: allow map_sha1_file_1 to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  101. 15/27 sha1_file: allow prepare_alt_odb to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  102. 12/27 sha1_file: add repository argument to link_alt_odb_entriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  103. 08/27 pack: move approximate object count to object storeNguyễn Thái Ngọc Duy, Mar 23, 2018
  104. 09/27 sha1_file: add raw_object_store argument to alt_odb_usableNguyễn Thái Ngọc Duy, Mar 23, 2018
  105. 11/27 sha1_file: add repository argument to read_info_alternatesNguyễn Thái Ngọc Duy, Mar 23, 2018
  106. 13/27 sha1_file: add repository argument to prepare_alt_odbNguyễn Thái Ngọc Duy, Mar 23, 2018
  107. 18/27 sha1_file: add repository argument to open_sha1_fileNguyễn Thái Ngọc Duy, Mar 23, 2018
  108. 19/27 sha1_file: add repository argument to map_sha1_file_1Nguyễn Thái Ngọc Duy, Mar 23, 2018
  109. 05/27 object-store: move packed_git and packed_git_mru to object storeNguyễn Thái Ngọc Duy, Mar 23, 2018
  110. 06/27 object-store: close all packs upon clearing the object storeNguyễn Thái Ngọc Duy, Mar 23, 2018
  111. 07/27 pack: move prepare_packed_git_run_once to object storeNguyễn Thái Ngọc Duy, Mar 23, 2018
  112. 01/27 repository: introduce raw object store fieldNguyễn Thái Ngọc Duy, Mar 23, 2018
  113. Brandon WilliamsMar 23, 2018
  114. Brandon WilliamsMar 23, 2018
  115. Junio C HamanoMar 23, 2018
  116. Duy NguyenMar 23, 2018
  117. Eric SunshineMar 23, 2018
  118. Duy NguyenMar 24, 2018
  119. Stefan BellerMar 26, 2018
  120. Junio C HamanoMar 26, 2018
  121. Junio C HamanoMar 26, 2018
  122. 00/12 sb/packfiles-in-repository updatesNguyễn Thái Ngọc Duy, Mar 23, 2018
  123. 01/12 packfile: allow prepare_packed_git_mru to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  124. 02/12 packfile: allow rearrange_packed_git to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  125. 06/12 packfile: add repository argument to reprepare_packed_gitNguyễn Thái Ngọc Duy, Mar 23, 2018
  126. 08/12 packfile: allow prepare_packed_git to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  127. 03/12 packfile: allow install_packed_git to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  128. 09/12 packfile: allow reprepare_packed_git to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  129. 07/12 packfile: allow prepare_packed_git_one to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  130. 05/12 packfile: add repository argument to prepare_packed_gitNguyễn Thái Ngọc Duy, Mar 23, 2018
  131. 10/12 packfile: add repository argument to find_pack_entryNguyễn Thái Ngọc Duy, Mar 23, 2018
  132. 11/12 packfile: allow find_pack_entry to handle arbitrary repositoriesNguyễn Thái Ngọc Duy, Mar 23, 2018
  133. 12/12 packfile: keep prepare_packed_git() privateNguyễn Thái Ngọc Duy, Mar 23, 2018
  134. 04/12 packfile: add repository argument to prepare_packed_git_oneNguyễn Thái Ngọc Duy, Mar 23, 2018
  135. Brandon WilliamsMar 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.