Re: [PATCH 0/4] vcs-svn: remove repo_tree library

From: Stefan Beller <sbeller@google.com>
Date: Aug 22, 2017, 23:44 UTC
Message-ID: <CAGZ79kbkLyYTrvkUfsfHsUJstq-7Mj=c8vz2aZVojcXsy1fhog@mail.gmail.com>
In-Reply-To: <20170822233732.GX13924@aiede.mtv.corp.google.com>

On Tue, Aug 22, 2017 at 4:37 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 14 quoted lines

> Hi,
>
> Stefan noticed that repo_init from vcs-svn/repo_tree.h conflicts with
> repository.h[1].  Earlier brian m. carlson noticed the same thing[2].
>
> Originally repo_tree.h was used to manage an in-memory representation
> of the state of the svn tree being imported.  When that in-memory
> representation was retired, we were lazy and left some utility
> functions there.  Here is a patch series to finish cleaning up and
> remove vcs-svn/repo_tree.h completely.
>
> This is an alternative to bc/vcs-svn-cleanup from 'next'.  Those
> patches weren't cc-ed to me and I missed them --- sorry about that.  I
> can rebase on top of them if that is more convenient.

A rebased version would be easier IIUC Junios reply to the one-off that I sent.

The patches look good.

Thanks, Stefan

Show 24 quoted lines

>
> Thoughts of all kinds welcome, as always.
>
> Thanks,
> Jonathan
>
> Jonathan Nieder (4):
>   vcs-svn: remove prototypes for missing functions
>   vcs-svn: remove custom mode constants
>   vcs-svn: remove repo_delete wrapper function
>   vcs-svn: move remaining repo_tree functions to fast_export.h
>
>  Makefile              |  1 -
>  vcs-svn/fast_export.c | 41 +++++++++++++++++++++++++++++++++++++----
>  vcs-svn/fast_export.h |  3 +++
>  vcs-svn/repo_tree.c   | 48 ------------------------------------------------
>  vcs-svn/repo_tree.h   | 23 -----------------------
>  vcs-svn/svndump.c     | 33 ++++++++++++++++-----------------
>  6 files changed, 56 insertions(+), 93 deletions(-)
>  delete mode 100644 vcs-svn/repo_tree.c
>  delete mode 100644 vcs-svn/repo_tree.h
>
> [1] https://public-inbox.org/git/20170822213501.5928-1-sbeller@google.com
> [2] https://public-inbox.org/git/20170821000022.26729-3-sandals@crustytoothpaste.net